-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding hover indicator for unselected tabs #2130
Adding hover indicator for unselected tabs #2130
Conversation
Test Results 1 815 files + 605 1 815 suites +605 1h 32m 1s ⏱️ + 39m 2s For more details on these failures, see this check. Results for commit ce7a011. ± Comparison against base commit 944c8db. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great on Windows. I had no chance to test on MacOS yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also looks good on MacOS. If no one objects, I would like to merge this until end of today to have some hovering indicator again.
For visual changes it is always good to include before/after in the PR so it is easier for those that don't have that specific OS at hand :-) Also I find it easier for reviewers as one then can directly comment on the provided screenshot. |
Fully agree. @mvm-sap, it would be great if you could share before/after screenshots already when opening the PR. For this one, since I have tested the change anyway, here are some screenshots showing what happens when hovering over the "Progress" view tab (in the bottom view stack): Windows (light)BeforeAfterWindows (dark)BeforeAfterMacOSSame as on Windows, thus only providing dark mode screenshots BeforeAfter |
d31d97a
to
ce7a011
Compare
Failing test is unrelated and already documented: #294 |
Hover indicators are included in both Dark and Light theme for unselected tabs in views and editors.
Light theme,
Editor tab's hover color is set to white
View tab's hover color is set to darker grey
Dark Theme,
Both Editor and View tab's hover color is set to darker black
Please find the details of this issue reported in #2114