remove unnecessary casts #1988
Merged
remove unnecessary casts #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you need help pushing any of these to completion just @ mention me. There’s a lot of action here so easy to lose track. And thanks 🙏 for being so proactive! ❤️ 🏅 |
@merks yea, I didn't expect a little compiler fix to reveal so much unnecessary stuff :) For an overview simply check the list of PRs mentioned on eclipse-jdt/eclipse.jdt.core#2471 |
stephan-herrmann
force-pushed
the
removeCasts
branch
from
a7c1e85
to
713aa0e
Compare
|
ready :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When eclipse-jdt/eclipse.jdt.core#2471 is merged, ecj will signal more casts as unnecessary.
With this PR I suggest to remove affected casts before new errors/warnings will show up in the build.