Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StickyScrolling] "Show line numbers" settings is not correctly handled #2269

Closed
1 task done
Tracked by #2152
Christopher-Hermann opened this issue Sep 13, 2024 · 0 comments · Fixed by #2328
Closed
1 task done
Tracked by #2152

[StickyScrolling] "Show line numbers" settings is not correctly handled #2269

Christopher-Hermann opened this issue Sep 13, 2024 · 0 comments · Fixed by #2328
Assignees
@Christopher-Hermann
Labels
bug Something isn't working

Comments

@Christopher-Hermann
Copy link
Contributor

Steps to reproduce

From a fresh installation and clean workspace:

  • Make sture the "Show line numbers" setting is active in the "Text editors" settings
  • Open a java class and scroll so that a sticky line with line number is visible
  • Disable the setting "Show line numbers" in the "Text editors" settings

I expected: The line number in the sticky scrolling should be hidden as well

I got: The line number in the sticky scrolling is still visible. See scrennshots:

Bildschirmfoto 2024-09-13 um 14 16 45 Bildschirmfoto 2024-09-13 um 14 16 31
@Christopher-Hermann Christopher-Hermann added the bug Something isn't working label Sep 13, 2024
@Christopher-Hermann Christopher-Hermann self-assigned this Sep 13, 2024
@Christopher-Hermann Christopher-Hermann mentioned this issue Sep 13, 2024
Open
8 tasks
Christopher-Hermann added a commit to Christopher-Hermann/eclipse.platform.ui that referenced this issue Sep 16, 2024
@Christopher-Hermann
Fix "Show line numbers" settings is not correctly handled
f4efe99 
When changing the "Show line numbers" setting for the editor, the sticky scrolling control should also react on the setting and hide the line numbers.

Fixes eclipse-platform#2269
Christopher-Hermann added a commit to Christopher-Hermann/eclipse.platform.ui that referenced this issue Sep 25, 2024
@Christopher-Hermann
Fix "Show line numbers" settings is not correctly handled
1c6976f 
When changing the "Show line numbers" setting for the editor, the sticky scrolling control should also react on the setting and hide the line numbers.

Fixes eclipse-platform#2269
@BeckerWdf BeckerWdf mentioned this issue Sep 26, 2024
Merged
Christopher-Hermann added a commit to Christopher-Hermann/eclipse.platform.ui that referenced this issue Sep 26, 2024
@Christopher-Hermann
Fix "Show line numbers" settings is not correctly handled
14eff16 
When changing the "Show line numbers" setting for the editor, the sticky scrolling control should also react on the setting and hide the line numbers.

Fixes eclipse-platform#2269
Christopher-Hermann added a commit to Christopher-Hermann/eclipse.platform.ui that referenced this issue Sep 26, 2024
@Christopher-Hermann
Fix "Show line numbers" settings is not correctly handled
04e7453 
When changing the "Show line numbers" setting for the editor, the sticky scrolling control should also react on the setting and hide the line numbers.

Fixes eclipse-platform#2269
Christopher-Hermann added a commit to Christopher-Hermann/eclipse.platform.ui that referenced this issue Sep 26, 2024
@Christopher-Hermann
Fix "Show line numbers" settings is not correctly handled
ed04e04 
When changing the "Show line numbers" setting for the editor, the sticky scrolling control should also react on the setting and hide the line numbers.

Fixes eclipse-platform#2269
praveen-skp pushed a commit to praveen-skp/eclipse.platform.ui that referenced this issue Oct 14, 2024
@Christopher-Hermann @praveen-skp
Fix "Show line numbers" settings is not correctly handled
74c6846 
When changing the "Show line numbers" setting for the editor, the sticky scrolling control should also react on the setting and hide the line numbers.

Fixes eclipse-platform#2269
lathapatil pushed a commit to lathapatil/eclipse.platform.ui that referenced this issue Oct 21, 2024
@Christopher-Hermann @lathapatil
Fix "Show line numbers" settings is not correctly handled
62a2444 
When changing the "Show line numbers" setting for the editor, the sticky scrolling control should also react on the setting and hide the line numbers.

Fixes eclipse-platform#2269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Christopher-Hermann Christopher-Hermann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@Christopher-Hermann