Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable UI Freeze Error log by default #2218

Open
jukzi opened this issue Aug 26, 2024 · 1 comment
Open

Disable UI Freeze Error log by default #2218

jukzi opened this issue Aug 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jukzi
Copy link
Contributor

jukzi commented Aug 26, 2024

When something takes long it is contra productive that the error log pops up and robs the focus, disturbing my work even more. It should do so on real errors, but some things simply take long. Therefore by default the error log should only pop up on errors and freezes should not be reported as errors.

image

Downgrading freezes error/warning to warnings/info does not work so good with public API likeorg.eclipse.ui.monitoring.PreferenceConstants.LONG_EVENT_ERROR_THRESHOLD_MILLIS

WDYT?
@jukzi jukzi added the enhancement New feature or request label Aug 26, 2024
jukzi pushed a commit to jukzi/eclipse.platform.ui that referenced this issue Aug 26, 2024
@EcljpseB0T
Error Log: do not pop up on info/warning/freeze by default eclipse-pl…
a60c4dd 
…atform#2218

As it is counterproductive to pop up error log when something took too
long.

eclipse-platform#2218
@jukzi jukzi mentioned this issue Aug 26, 2024
Merged
@vogella
Copy link
Contributor

vogella commented Aug 26, 2024

IMHO this change is fine. The period in which I hoped that all long operations will run out of the UI thread has passed, looks like this expectation was unrealistic.

I would not do this shortly before the release , better to wait for a new release cycle.

jukzi pushed a commit to jukzi/eclipse.platform.ui that referenced this issue Aug 26, 2024
@EcljpseB0T
Error Log: do not pop up on info/warning/freeze by default eclipse-pl…
d6ee29a 
…atform#2218

As it is counterproductive to pop up error log when something took too
long.

eclipse-platform#2218
jukzi pushed a commit to jukzi/eclipse.platform.ui that referenced this issue Sep 5, 2024
@EcljpseB0T @jukzi
Error Log: do not pop up on info/warning/freeze by default eclipse-pl…
f6fe03a 
…atform#2218

As it is counterproductive to pop up error log when something took too
long.

eclipse-platform#2218
jukzi pushed a commit to jukzi/eclipse.platform.ui that referenced this issue Sep 5, 2024
@EcljpseB0T
Error Log: do not pop up on info/warning/freeze by default eclipse-pl…
fe2027c 
…atform#2218

As it is counterproductive to pop up error log when something took too
long.

eclipse-platform#2218
jukzi pushed a commit that referenced this issue Sep 5, 2024
@EcljpseB0T @jukzi
Error Log: do not pop up on info/warning/freeze by default #2218
41abe79 
As it is counterproductive to pop up error log when something took too
long.

#2218
lathapatil pushed a commit to lathapatil/eclipse.platform.ui that referenced this issue Oct 21, 2024
@EcljpseB0T @lathapatil
Error Log: do not pop up on info/warning/freeze by default eclipse-pl…
76e2c63 
…atform#2218

As it is counterproductive to pop up error log when something took too
long.

eclipse-platform#2218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vogella @jukzi