Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Further streamlining and simplifications of SWT build pipeline #988

Merged

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Jan 19, 2024

Increment the Library revision also for enforced native binary re-builds. Besides allowing simplifications of the build, this ensures
the git-based qualifier of the org.eclipse.swt and consequently its native fragments (which use the same qualifier) is updated in that case and a subsequently 'manually' enforced qualifier update is not necessary. Furthermore letter-suffixes for revision git tags are not necessary too.

And remove superfluous steps.

Part of #513

Copy link
Contributor

github-actions bot commented Jan 19, 2024

Test Results

   299 files  ±0     299 suites  ±0   6m 12s ⏱️ -1s
 4 098 tests ±0   4 090 ✅ ±0   8 💤 ±0  0 ❌ ±0 
12 206 runs  ±0  12 133 ✅ ±0  73 💤 ±0  0 ❌ ±0 

Results for commit a3254da. ± Comparison against base commit 5c9180b.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the build-pipeline-simplifications branch 2 times, most recently from 9b917f7 to 05eee19 Compare January 19, 2024 21:48
@HannesWell HannesWell changed the title [Build] Further build pipeline simplifications [Build] Further stream-lining and simplifications of SWT build pipeline Jan 20, 2024
@HannesWell HannesWell force-pushed the build-pipeline-simplifications branch 6 times, most recently from c8fbc4f to a914760 Compare January 21, 2024 09:32
@HannesWell HannesWell changed the title [Build] Further stream-lining and simplifications of SWT build pipeline [Build] Further streamlining and simplifications of SWT build pipeline Jan 21, 2024
@HannesWell HannesWell force-pushed the build-pipeline-simplifications branch from a914760 to b248d25 Compare January 21, 2024 09:43
Increment the Library revision also for enforced native binary
re-builds. Besides allowing simplifications of the build, this ensures
the git-based qualifier of the org.eclipse.swt and consequently its
native fragments (which use the same qualifier) is updated in that case
and a subsequently 'manually' enforced qualifier update is not
necessary. Furthermore letter-suffixes for revision git tags are not
necessary too.

Remove superfluous steps.

Part of eclipse-platform#513
@HannesWell HannesWell force-pushed the build-pipeline-simplifications branch from b248d25 to a3254da Compare January 21, 2024 15:04
@HannesWell
Copy link
Member Author

Use the org.eclipse.cbi.maven.plugins:eclipse-winsigner-plugin Maven plug-in to sign the built binaries instead of bash-scripts.

I now dropped this idea again, since it took much longer to sign the binaries even with a single goal execution maven build (about a minute) compared to just curl-ing the binaries to sign as was already done (a few seconds).

@HannesWell HannesWell marked this pull request as ready for review January 21, 2024 15:07
@HannesWell HannesWell merged commit c269aeb into eclipse-platform:master Jan 21, 2024
13 checks passed
@HannesWell HannesWell deleted the build-pipeline-simplifications branch January 21, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant