Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build gtk.linux.riscv64 native SWT fragment #1474

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

Sakura286
Copy link
Contributor

@Sakura286 Sakura286 commented Sep 18, 2024

With command

mvn verify -DskipTests=true -Dnative=gtk.linux.riscv64

riscv64 artifact can be generated at binaries/org.eclipse.swt.gtk.linux.riscv64/target/

Copy link
Contributor

github-actions bot commented Sep 18, 2024

Test Results

   486 files  ±0     486 suites  ±0   6m 56s ⏱️ -11s
 4 159 tests ±0   4 151 ✅ ±0   8 💤 ±0  0 ❌ ±0 
16 390 runs  ±0  16 298 ✅ ±0  92 💤 ±0  0 ❌ ±0 

Results for commit 22fc519. ± Comparison against base commit c305b75.

♻️ This comment has been updated with latest results.

@Sakura286
Copy link
Contributor Author

According to the error log in GitHub CI

Error:  Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:4.0.8:package-plugin (default-package-plugin) on project org.eclipse.swt.gtk.linux.riscv64: /home/runner/work/eclipse.platform.swt/eclipse.platform.swt/binaries/org.eclipse.swt.gtk.linux.riscv64/build.properties: bin.includes value(s) [*.so] do not match any files. -> [Help 1]

Should the *.so files be uploaded manually first?

@akurtakov
Copy link
Member

*.so files should be generated by the jenkins build. I would leave it to @HannesWell to tell us what is the status here. IIRC equinox is currently blocked by https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4978#note_2820978 and swt has more or less same requirements and should share the same machine.

@HannesWell HannesWell self-requested a review September 21, 2024 14:56
@yuzibo
Copy link
Contributor

yuzibo commented Sep 23, 2024

Sorry. Can I know when the PR can be merged? maybe this is still blocked by the ticket.:)

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we need to have the same work-around in the Jenkinsfile of this project like in Equinox to obtain the JDK the natives are built against:
https://github.com/eclipse-equinox/equinox/blob/ef8e0438b0704a5fb8c6cd323081f63c7f04a3ba/Jenkinsfile#L50-L62

After adding this, please also squash all your commits into one with a message covering this change as a whole, e.g.:
Build gtk.linux.riscv64 native SWT fragment

@Sakura286
Copy link
Contributor Author

Now the patch is ready for review.

@HannesWell HannesWell mentioned this pull request Sep 25, 2024
@HannesWell HannesWell changed the title Add gtk.linux.riscv64 option for swt bundle Build gtk.linux.riscv64 native SWT fragment Sep 25, 2024
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added the changes from #1490 so that we have a clean version.

Looks good now.

Thank you.

@HannesWell
Copy link
Member

The initial build cannot succeed in the GH workflows because the native binaries are not yet present.

Submitting for the initial build.

@HannesWell HannesWell merged commit be019b2 into eclipse-platform:master Sep 25, 2024
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants