-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build gtk.linux.riscv64 native SWT fragment #1474
Conversation
According to the error log in GitHub CI
Should the |
*.so files should be generated by the jenkins build. I would leave it to @HannesWell to tell us what is the status here. IIRC equinox is currently blocked by https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4978#note_2820978 and swt has more or less same requirements and should share the same machine. |
Sorry. Can I know when the PR can be merged? maybe this is still blocked by the ticket.:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now we need to have the same work-around in the Jenkinsfile of this project like in Equinox to obtain the JDK the natives are built against:
https://github.com/eclipse-equinox/equinox/blob/ef8e0438b0704a5fb8c6cd323081f63c7f04a3ba/Jenkinsfile#L50-L62
After adding this, please also squash all your commits into one with a message covering this change as a whole, e.g.:
Build gtk.linux.riscv64 native SWT fragment
d7f597a
to
bd6efad
Compare
Now the patch is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial build cannot succeed in the GH workflows because the native binaries are not yet present. Submitting for the initial build. |
With command
riscv64 artifact can be generated at
binaries/org.eclipse.swt.gtk.linux.riscv64/target/