-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge: Improve handling of LocationListener#changed() #1451
Conversation
60f1e0d
to
8cbe448
Compare
if (url.startsWith("data:text/html;")) { | ||
url = "about:blank"; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check whether this conflicts with #1395
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That part is now obsolete, as no more data:text/html URLs occur with #1395 merged.
8cbe448
to
30555ed
Compare
Previously, the changed() method was not called consistently. Move the firing of 'changed' LocationEvents in Edge from handleSourceChanged() to handleNavigationCompleted(). Add a test case to Test_org_eclipse_swt_browser_Browser for this scenario (setText() twice).
30555ed
to
932b4a2
Compare
Also added a test case for this scenario. If there are no objections I'd like to merge this Today, so that it's available in the I-builds on Monday. |
Previously, the changed() method was not called consistently.
Move the firing of 'changed' LocationEvents in Edge from handleSourceChanged() to handleNavigationCompleted().
Fixes #1464.