[GTK4] Migrate DirectoryDialog from GtkFileChooser to GtkFileDialog #1421
+136
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributes to #652 For comparison, the "current" GTK3-based directory dialog: And the "new" GTK4-based directory dialog: |
|
Looks promising.Please ping me in 2 weeks if I haven't reviewed it yet as we are in a freeze now. |
ptziegler
force-pushed
the
gtk4-file-dialog
branch
3 times, most recently
from
03cea78
to
e3d777a
Compare
akurtakov
force-pushed
the
gtk4-file-dialog
branch
4 times, most recently
from
92f1acf
to
f8a2840
Compare
The FileChooser has been marked as deprecated with GTK 4.10 with the FileDialog being its replacement. Using this new API poses a challenge, as it requires the usage of the AsyncReadyCallback mechanism in order to respond to the closure of the dialog. Once the dialog has been opened via gtk_file_dialog_select_folder(), it is necessary to call gtk_file_dialog_select_folder_finish() from within the callback method. This method also returns the selected folder, which has to be cached until after the dialog has been closed. Following native methods have been added to GTK4: - gtk_file_dialog_new - gtk_file_dialog_select_folder - gtk_file_dialog_select_folder_finish - gtk_file_dialog_set_initial_folder
akurtakov
force-pushed
the
gtk4-file-dialog
branch
from
f8a2840
to
d4e0a6b
Compare
akurtakov
reviewed
Sep 16, 2024
| /** | ||
| * @param self cast=(GtkFileDialog *) | ||
| * @param result cast=(GAsyncResult *) | ||
| * @param error cast=(GError *) |
There was a problem hiding this comment.
Should be '(GError **)'. What you have here fails with
gtk4.c:737:103: error: passing argument 3 of ‘gtk_file_dialog_select_folder_finish’ from incompatible pointer type [-Wincompatible-pointer-types]
737 | rc = (jlong)gtk_file_dialog_select_folder_finish((GtkFileDialog *)arg0, (GAsyncResult *)arg1, (GError *)lparg2);
| ^~~~~~~~~~~~~~~~
| |
| GError * {aka struct _GError *}
In file included from /usr/include/gtk-4.0/gtk/gtk.h:134,
from gtk4.h:23,
from gtk4_structs.h:18,
from gtk4.c:19:
/usr/include/gtk-4.0/gtk/gtkfiledialog.h:118:77: note: expected ‘GError **’ {aka ‘struct _GError **’} but argument is of type ‘GError *’ {aka ‘struct _GError *’}
118 | GError **error);
| ~~~~~~~~~~~~~~~~~~~~~~^~~~~
akurtakov
reviewed
Sep 16, 2024
|
|
||
| import org.eclipse.swt.*; |
|
Fixed version is in #1473 in order to get this one in while I am at it. |
|
My apologies for the belated response. The past few days have been a little hectic... |
NP, Thanks again for the patch and keep'em coming! I would love to see the GTK 4 port shape better and better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FileChooser has been marked as deprecated with GTK 4.10 with the FileDialog being its replacement. Using this new API poses a challenge, as it requires the usage of the AsyncReadyCallback mechanism in order to respond to the closure of the dialog.
Once the dialog has been opened via gtk_file_dialog_select_folder(), it is necessary to call gtk_file_dialog_select_folder_finish() from within the callback method. This method also returns the selected folder, which has to be cached until after the dialog has been closed.
Following native methods have been added to GTK4: