remove unnecessary casts

[stephan-herrmann]

When eclipse-jdt/eclipse.jdt.core#2471 is merged, ecj will signal more casts as unnecessary.

With this PR I suggest to remove affected casts before new warnings will show up in the build.

[akurtakov]

Version bump required:
Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.8:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.swt.tools: Only qualifier changed for (org.eclipse.swt.tools/3.110.400.v20240620-1554). Expected to have bigger x.y.z than what is available in baseline (3.110.400.v20240321-1321) -> [Help 1]

[github-actions]

Test Results

   450 files  ±0     450 suites  ±0   7m 34s ⏱️ +48s
 4 127 tests ±0   4 119 ✅ ±0   8 💤 ±0  0 ❌ ±0 
16 319 runs  ±0  16 227 ✅ ±0  92 💤 ±0  0 ❌ ±0 

Results for commit d2453d6. ± Comparison against base commit f708ac3.

♻️ This comment has been updated with latest results.

[stephan-herrmann]

Error:  Failed to execute goal org.eclipse.tycho:tycho-p2-plugin:4.0.8:p2-metadata-default (default-p2-metadata-default) on project org.eclipse.swt.gtk.linux.ppc64le: Execution default-p2-metadata-default of goal org.eclipse.tycho:tycho-p2-plugin:4.0.8:p2-metadata-default failed: Error trying to download org.eclipse.swt.gtk.linux.ppc64le version 3.126.100.v20240619-0913 from https://download.eclipse.org/eclipse/updates/4.33-I-builds/I20240619-1800:
Error:  Download of osgi.bundle,org.eclipse.swt.gtk.linux.ppc64le,3.126.100.v20240619-0913 failed on repository https://download.eclipse.org/eclipse/updates/4.33-I-builds/I20240619-1800. Retrying. :
Error:     download from https://download.eclipse.org/eclipse/updates/4.33-I-builds/I20240619-1800/plugins/org.eclipse.swt.gtk.linux.ppc64le_3.126.100.v20240619-0913.jar failed: request timed out
Error:  -> [Help 1]

[merks]

I restarted it.

[stephan-herrmann]

@merks I'm stuck here, again timeout .. or did I miss another version bump or such?

Perhaps SWT build requires a more gentle push :)

[akurtakov]

I see Caused by: org.eclipse.tycho.core.exceptions.VersionBumpRequiredException: Only qualifier changed for (org.eclipse.swt.tools.feature.feature.jar/3.109.400.v20240620-1633). Expected to have bigger x.y.z than what is available in baseline (3.109.400.v20240321-1321) in the build log (https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/PR-1293/3/console)

[merks]

Reading the meaning in the tea leaves is an art not a science.

[stephan-herrmann]

I see Caused by: org.eclipse.tycho.core.exceptions.VersionBumpRequiredException: Only qualifier changed for (org.eclipse.swt.tools.feature.feature.jar/3.109.400.v20240620-1633). Expected to have bigger x.y.z than what is available in baseline (3.109.400.v20240321-1321) in the build log (https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/PR-1293/3/console)

Thanks, I got lost on some of those click paths :)

BTW, perhaps I should have seen the need for each and every version bump already in Eclipse, but somehow my oomph'ed SDK workspace showed lots of API problems already before I started making changes. Perhaps my Modular API Baseline has gone stale, although it says Platform is 2024-06 ... nevermind ...

[stephan-herrmann]

Reading the meaning in the tea leaves is an art not a science.

I like them all:

• reading
• meaning
• tea leaves
• art
• science

[merks]

You do need to pull all git repos and perform setup tasks regularly. The api baseline update always seems particularly error prone. Sometimes I delete it to ensure a new updated one is created.

In any case, the horrible baseline qualify problems are never reported by that api tools. You learn to anticipate them by checking if the version has been incremented in the current release cycle when you change something that will change the byte code. Or wait for endless build cycles.

[stephan-herrmann]

More tea leaves in https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/PR-1293/4/pipeline-console/

20:55:58  /home/jenkins/agent/workspace/eclipse.platform.swt_PR-1293/eclipse.platform.swt@tmp/durable-7bd4213b/script.sh.copy: line 2:   387 Killed                  mvn clean verify --batch-mode --threads 1C -V -U -e -DforkCount=0 -Papi-check -Dcompare-version-with-baselines.skip=false -Dorg.eclipse.swt.tests.junit.disable.test_isLocal=true -Dmaven.test.failure.ignore=true -Dmaven.test.error.ignore=true
script returned exit code 137

[akurtakov]

Restarted build.

[merks]

It’s not even the dreaded killed because you used too much memory error.

[merks]

@akurtakov

I don’t think you get thanked nearly enough. I think we take it for granted that you work in the background to grease the wheels that keep everything running smoothly. 🏆