Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[I-Build-Tests] Use JDK23-EA for Linux-Java23 tests #2523

Conversation

HannesWell
Copy link
Member

@HannesWell
Copy link
Member Author

The verification build does not test this, but I tested it in my local Jenkins by replying the existing job with the changes applied and I'm to test this instead.

@HannesWell HannesWell force-pushed the linux-iBuild-tests-use-jdk23-ea branch from 828ada8 to 5425912 Compare November 6, 2024 23:03
@HannesWell HannesWell merged commit 127509b into eclipse-platform:master Nov 6, 2024
3 of 4 checks passed
@HannesWell HannesWell deleted the linux-iBuild-tests-use-jdk23-ea branch November 6, 2024 23:04
@jukzi
Copy link
Contributor

jukzi commented Nov 7, 2024

jdt.ui tests still fail. To fix we need a jdk after 2024-10-27 .

[echoproperties] java.vendor.version=Temurin-23+37-202410121216
[echoproperties] java.version=23.0.1-beta
[echoproperties] java.version.date=2024-10-15

https://download.eclipse.org/eclipse/downloads/drops4/I20241107-0510/testresults/consolelogs/ep434I-unit-linux-x86_64-java23_linux.gtk.x86_64_23_consolelog.txt

@HannesWell
Copy link
Member Author

HannesWell commented Nov 7, 2024

It's a bit confusing when looking at https://adoptium.net/de/temurin/nightly/?version=23,
there are some builds from 4. November 2024, but they have tagged with 23.0.1-beta+11-202411021221 and I assume
23.0.1-beta+11 is older newer than 23+37 ?
But I'm not sure what is right and what's wrong here.

In general if anybody can provide me a link to a better JDK it can be changed easily.
At the moment we use
https://staging-api.adoptium.net/v3/binary/latest/23/ea/linux/x64/jdk/hotspot/normal/eclipse?project=jdk
This should download the latest early access build of JDK 23?

@akurtakov
Copy link
Member

akurtakov commented Nov 8, 2024

I believe 23+37 means build 37 of stream 23.0.0, while 23.0.1-beta+11 means build 11 of stream 23.0.1 - aka the later is newer as it's beta builds towards 23.0.1 and this is what we need as the fix is done after 23(.0.0) release.

@HannesWell
Copy link
Member Author

I believe 23+37 means build 37 of stream 23.0.0, while 23.0.1-beta+11 means build 11 of stream 23.0.1 - aka the later is newer as it's beta builds towards 23.0.1 and this is what we need as the fix is done after 23(.0.0) release.

Yes that's what I assume as well. And looking throught the nightly builds I have the impression that the Adoptium project somehow has messed up the semantic versions of the JDK 23 nightly builds.

I have the impression that https://github.com/adoptium/temurin23-binaries/releases/tag/jdk-23.0.1%2B11 is the most recent JDK-23 build available, but I don't see a newer one here:
https://github.com/adoptium/temurin23-binaries/releases

So we probably just have to wait for a new build.

@HannesWell
Copy link
Member Author

I now wanted to try out
https://github.com/adoptium/temurin23-binaries/releases/download/jdk23u-2024-11-04-10-15-beta/OpenJDK23U-jdk_x64_linux_hotspot_2024-11-04-10-15.tar.gz

But in the latest I-builds the JDT failures for java-23 seem to be gone.
@jukzi do you know if a fix has been applied in JDT?

@jukzi
Copy link
Contributor

jukzi commented Nov 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaLeakTests failing on Java 23
3 participants