remove unnecessary casts

[stephan-herrmann]

When eclipse-jdt/eclipse.jdt.core#2471 is merged, ecj will signal more casts as unnecessary.

With this PR I suggest to remove affected casts before new errors/warnings will show up in the build.

[github-actions]

Test Results

   289 files  ±0     289 suites  ±0   58m 39s ⏱️ - 1m 6s
 3 578 tests ±0   3 501 ✅  - 1   77 💤 +1  0 ❌ ±0 
10 865 runs  ±0  10 662 ✅  - 1  203 💤 +1  0 ❌ ±0 

Results for commit 7eb2e02. ± Comparison against base commit 34453f9.

This pull request skips 1 test.

org.eclipse.pde.build.internal.tests.p2.P2Tests ‑ offBug237662

♻️ This comment has been updated with latest results.

[stephan-herrmann]

MacOS build is unhappy:

Error:  Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.8:verify (verify) on project org.eclipse.tools.layout.spy: Execute ApiApplication failed: InvocationTargetException: Component 'Layout Spy' in the baseline 'workspace' is disposed: Component was disposed here -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.8:verify (verify) on project org.eclipse.tools.layout.spy: Execute ApiApplication failed

@merks any idea?

[akurtakov]

As long as Jenkins is fine it's good to go.

[stephan-herrmann]

As long as Jenkins is fine it's good to go.

thanks!

[HannesWell]

Thanks for this PR. It's great to have the code, base cleaned-up a bit.

MacOS build is unhappy:

Error:  Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.8:verify (verify) on project org.eclipse.tools.layout.spy: Execute ApiApplication failed: InvocationTargetException: Component 'Layout Spy' in the baseline 'workspace' is disposed: Component was disposed here -

The baseline check is unfortunately flaky sometimes.