-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support version ranges and no versions for units in target definitions #1245
base: master
Are you sure you want to change the base?
Support version ranges and no versions for units in target definitions #1245
Conversation
Test Results 273 files - 18 273 suites - 18 36m 47s ⏱️ - 28m 1s For more details on these errors, see this check. Results for commit 42ebff6. ± Comparison against base commit b8c244d. This pull request removes 2626 tests.
|
I guess support for this in tycho is implemented separately. |
Yes that's the only drawback this will immediately make the target file incompatible to any older Eclipse or Tycho version :-\ Theoretically there is a "target version" processing instruction, so maybe we should try to use that to make at least PDE aware of the incompatibility? |
Just one thing about the UI I think in such a case we should adapt the labelprovider to show the range + the resolved version. Also then we need some UI to edit the version (range) e.g. in the wizard there could be an additional radio option to use:
and of course the most challenging thing will be if one edit such a location so it retains the exiting version ranges. |
This is an early draft to add support for version ranges and no versions for
unit
elements in target-definitions.This allows users to omit the
version
attribute in aunit
element (which is equivalent to the value0.0.0
) or to specify a range (in the usual OSGi synax) as its value.For example:
Resolves to
This also contains two commits with code clean-ups in the target handling that I plan to provide as separate PR soon.
There are still a few things to work out regarding removal of IUs and Updating the target and the UI should probably also be adapted, but the most basic functionality is already working.
Fixes #757