Update API workaround for tycho bundle names containing dashes #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tycho/maven renames original bundles and replaces underscore with dash, so let our "expected" 4.31 bundle file patches have everything with dashes. That should work in IDE / on tycho build. See eclipse-platform/eclipse.platform.swt#1011 See eclipse-pde#1187
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Sep 8, 2024
This reverts commit 2fd4268 and commit a6824f7, introduced with eclipse-pde#1191 and eclipse-pde#1192 These workarounds for missing API description files are not necessary anymore because they are now correctly included again for some time.
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Sep 9, 2024
This reverts commit 2fd4268 and commit a6824f7, introduced with eclipse-pde#1191 and eclipse-pde#1192 These workarounds for missing API description files are not necessary anymore because they are now correctly included again for some time.
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Sep 19, 2024
This reverts commit 2fd4268 and commit a6824f7, introduced with eclipse-pde#1191 and eclipse-pde#1192 These workarounds for missing API description files are not necessary anymore because they are now correctly included again for some time.
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Sep 24, 2024
This reverts commit 2fd4268 and commit a6824f7, introduced with eclipse-pde#1191 and eclipse-pde#1192 These workarounds for missing API description files are not necessary anymore because they are now correctly included again for some time.
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Sep 24, 2024
This reverts commit 2fd4268 and commit a6824f7, introduced with eclipse-pde#1191 and eclipse-pde#1192 These workarounds for missing API description files are not necessary anymore because they are now correctly included again for some time.
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Sep 25, 2024
This reverts commit 2fd4268 and commit a6824f7, introduced with eclipse-pde#1191 and eclipse-pde#1192 These workarounds for missing API description files are not necessary anymore because they are now correctly included again for some time.
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Sep 25, 2024
This reverts commit 2fd4268 and commit a6824f7, introduced with eclipse-pde#1191 and eclipse-pde#1192 These workarounds for missing API description files are not necessary anymore because they are now correctly included again for some time.
HannesWell
added a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tycho/maven renames original bundles and replaces underscore with dash, so let our "expected" 4.31 bundle file patches have everything with dashes. That should work in IDE / on tycho build.
See eclipse-platform/eclipse.platform.swt#1011
See #1187