Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standard OSGi plugin creation settings mutates the creation wizard #566

Closed
gireeshpunathil opened this issue Apr 6, 2023 · 2 comments · Fixed by #569
Closed

standard OSGi plugin creation settings mutates the creation wizard #566

gireeshpunathil opened this issue Apr 6, 2023 · 2 comments · Fixed by #569
Assignees
@laeubi
Labels
regression Regression defect
Milestone
4.28 M2

Comments

@gireeshpunathil
Copy link
Contributor

steps to recreate:

  1. project -> plugin project
  2. select OSGi standard type
  3. finish
  4. create another plugin project
  5. this time select Eclipse as the target type
  6. the next button is now disabled, disallowing to create plugins from templates
  7. clean / change the workspace to restore the original behaviour

probably related : #550

/cc @laeubi
@laeubi laeubi self-assigned this Apr 6, 2023
@HannesWell HannesWell mentioned this issue Apr 6, 2023
Closed
13 tasks
@laeubi
Copy link
Contributor

laeubi commented Apr 7, 2023

I have looked into this and the problem seem when "Generate OSGi Metadata automatically" is checked, so a workaround is to first uncheck that option and then switch to "Eclipse" project type, will now look into it why it is considered even when not selected...

laeubi added a commit to laeubi/eclipse.pde that referenced this issue Apr 7, 2023
@laeubi
Automatic flag in TemplateListSelectionPage must check if OSGi is active
12e4733 
The "automatic" flag is actually bound to the enablement of an OSGi
Framework project type, so we need to disable it when OSGI is not
selected.

Fix eclipse-pde#566
@laeubi laeubi mentioned this issue Apr 7, 2023
Merged
@laeubi laeubi added the regression Regression defect label Apr 7, 2023
@laeubi laeubi added this to the 4.28 M1 milestone Apr 7, 2023
@vik-chand
Copy link
Member

Let's fix this in 4.28M2

@laeubi laeubi modified the milestones: 4.28 M1, 4.28 M2 Apr 7, 2023
HannesWell pushed a commit to laeubi/eclipse.pde that referenced this issue Apr 11, 2023
@laeubi @HannesWell
Automatic flag in TemplateListSelectionPage must check if OSGi is active
7092f4a 
The "automatic" flag is actually bound to the enablement of an OSGi
Framework project type, so we need to disable it when OSGI is not
selected.

Fix eclipse-pde#566
HannesWell pushed a commit that referenced this issue Apr 12, 2023
@laeubi @HannesWell
Automatic flag in TemplateListSelectionPage must check if OSGi is active
bcac5a3 
The "automatic" flag is actually bound to the enablement of an OSGi
Framework project type, so we need to disable it when OSGI is not
selected.

Fix #566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laeubi laeubi

Labels
regression Regression defect
Projects
None yet
Milestone
4.28 M2
Development

Successfully merging a pull request may close this issue.

Automatic flag in TemplateListSelectionPage must check if OSGi is active laeubi/eclipse.pde
3 participants
@laeubi @gireeshpunathil @vik-chand