Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target file - Remove the need to specify a 0.0.0 version #757

Open
vogella opened this issue Sep 22, 2023 · 1 comment · May be fixed by #1245
Open

Target file - Remove the need to specify a 0.0.0 version #757

vogella opened this issue Sep 22, 2023 · 1 comment · May be fixed by #1245

Comments

@vogella
Copy link
Contributor

vogella commented Sep 22, 2023

Currently lots of my target files so not specify a specific version, e.g.

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?pde version="3.8"?>
<target name="target-platform">
	<locations>
		<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
			<repository location="https://download.eclipse.org/releases/latest"/>
			<unit id="org.eclipse.equinox.compendium.sdk.feature.group" version="0.0.0"/>
			<unit id="org.eclipse.equinox.core.feature.feature.group" version="0.0.0"/>
		</location>
	</locations>
</target>

Would be nice if we could leave out version="0.0.0" in the file and use 0.0.0 as default if not specified in the file.
@HannesWell
Copy link
Member

Looks like this is a recurring topic: #405

But I agree with you, I also often had the impression that it is unnecessary. And it looks like relatively simple to implement in IULocationFactory. Of course Tycho needs to be adapted as well, but it also should be similar simple.

@laeubi's suggestion to also support this in the UI also seems reasonable to me that one can select that as well.

HannesWell added a commit to HannesWell/eclipse.pde that referenced this issue Apr 21, 2024
@HannesWell
Support no version and version ranges in target definitions
42ebff6 
Fixes eclipse-pde#757
TODO: search for more issues?!
@HannesWell HannesWell linked a pull request Apr 21, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support version ranges and no versions for units in target definitions HannesWell/eclipse.pde
2 participants
@vogella @HannesWell