Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libdwarf-dev (needed by OMR ddrgen) #461

Merged
merged 1 commit into from
Oct 26, 2017

Conversation

keithc-ca
Copy link
Contributor

Docker containers need to include libdwarf-dev that is required when enabling DDR in OMR.

@keithc-ca keithc-ca requested a review from pshipton October 26, 2017 18:08
@jdekonin
Copy link
Contributor

I verified ppcle and s390 dockerfiles build with this new addition.

@mstoodle
Copy link
Contributor

Will this requirement also impact the build machine configuration for our project and at AdoptOpenJDK?

@keithc-ca
Copy link
Contributor Author

We want DDR support in OpenJ9 (see #378) making use of the ddrgen tool of OMR. That tool requires OMR to be configured with --enable-DDR which in turn requires libdwarf-dev, so yes, build machines (including those at AdoptOpenJDL) will need that package installed.

@pshipton pshipton merged commit 5f75dfd into eclipse-openj9:master Oct 26, 2017
@keithc-ca keithc-ca deleted the docker-ddr-support branch October 26, 2017 20:19
@DanHeidinga
Copy link
Member

@keithc-ca Have we communicated the requirement for libdwarf to the AdoptOpenJDK project? We should try to pre-stage this change so their build environment is ready for --enable-DDR to be the default.

@smlambert
Copy link
Contributor

adoptium/temurin-build#182

@mstoodle
Copy link
Contributor

mstoodle commented Nov 13, 2017

For the record, AdoptOpenJDK's ubuntu and RHEL7 machines already have libdwarf installed, so I think we're already covered at AdoptOpenJDK, at least for existing builds there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants