Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amd64-osx-gcc.mk platform file for the JIT #3331

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

nbhuiyan
Copy link
Member

@nbhuiyan nbhuiyan commented Oct 17, 2018

This is needed for building OpenJ9 with gcc when using older versions of
XCode.

amd64-osx-clang.mk is still going to be the default makefile used
unless "PLATFORM" environment variable is set.

Signed-off-by: Nazim Uddin Bhuiyan [email protected]

Closes: #3326

Note: You must set the PLATFORM variable as amd64-osx-gcc in order to make use of this makefile.

This is needed for building OpenJ9 with gcc when using older
versions of XCode.

amd64-osx-clang.mk is still going to be the default makefile used
unless "PLATFORM" environment variable is set.

Signed-off-by: Nazim Uddin Bhuiyan <[email protected]>
@nbhuiyan
Copy link
Member Author

@babsingh agreed that he will set the PLATFORM variable in the JDK8 extensions repo

@0xdaryl @DanHeidinga fyi

@DanHeidinga
Copy link
Member

@nbhuiyan See also the change in this PR to ensure that PRODUCT is set - #3215

Does that need to be changed to work with this?

@nbhuiyan
Copy link
Member Author

nbhuiyan commented Oct 17, 2018

@DanHeidinga, changes to runtime/compiler/makefile.ftl proposed in #3215 would prevent us from making use of this file and would not solve the problem with building using gcc on older XCode, as this would override whatever we set PLATFORM to and prevent building OpenJ9 with JDK8. One (hacky) way to deal with this is to check for the VERSION_MAJOR variable in makefile.ftl, and set PLATFORM to amd64-osx-gcc for version 8. This would also remove the need to set it in the jdk extensions or manually when building with JDK8. How do you think this can be handled?

@babsingh
Copy link
Contributor

babsingh commented Oct 17, 2018

I incorporated runtime/compiler/build/platform/host/amd64-osx-gcc.mk in openj9. Set export PLATFORM := amd64-osx-gcc in the extension repo (custom-spec.gmk.in). Compiler option -Werror=header-guard wasn't used. JDK8 built properly on OSX.

@DanHeidinga
Copy link
Member

Change looks fine to me. @nbhuiyan Can you remove the WIP?

Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @0xdaryl any comments on this?

@DanHeidinga
Copy link
Member

issue #36

@nbhuiyan nbhuiyan changed the title WIP: Add amd64-osx-gcc.mk platform file for the JIT Add amd64-osx-gcc.mk platform file for the JIT Oct 18, 2018
@DanHeidinga
Copy link
Member

Jenkins compile xlinux jdk8

@DanHeidinga DanHeidinga self-assigned this Oct 18, 2018
@DanHeidinga DanHeidinga merged commit f5fc82b into eclipse-openj9:master Oct 18, 2018
@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 18, 2018

Posthumously looks fine to me.

jdekonin added a commit to jdekonin/openj9 that referenced this pull request Oct 18, 2018
* [skip ci]
* related to eclipse-openj9#3331

Signed-off-by: Joe deKoning <[email protected]>
acrowthe pushed a commit to acrowthe/openj9 that referenced this pull request Nov 5, 2018
* [skip ci]
* related to eclipse-openj9#3331

Signed-off-by: Joe deKoning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants