-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add amd64-osx-gcc.mk platform file for the JIT #3331
Conversation
This is needed for building OpenJ9 with gcc when using older versions of XCode. amd64-osx-clang.mk is still going to be the default makefile used unless "PLATFORM" environment variable is set. Signed-off-by: Nazim Uddin Bhuiyan <[email protected]>
@babsingh agreed that he will set the PLATFORM variable in the JDK8 extensions repo @0xdaryl @DanHeidinga fyi |
@DanHeidinga, changes to |
I incorporated |
Change looks fine to me. @nbhuiyan Can you remove the WIP? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. @0xdaryl any comments on this?
issue #36 |
Jenkins compile xlinux jdk8 |
Posthumously looks fine to me. |
* [skip ci] * related to eclipse-openj9#3331 Signed-off-by: Joe deKoning <[email protected]>
* [skip ci] * related to eclipse-openj9#3331 Signed-off-by: Joe deKoning <[email protected]>
This is needed for building OpenJ9 with gcc when using older versions of
XCode.
amd64-osx-clang.mk is still going to be the default makefile used
unless "PLATFORM" environment variable is set.
Signed-off-by: Nazim Uddin Bhuiyan [email protected]
Closes: #3326
Note: You must set the PLATFORM variable as
amd64-osx-gcc
in order to make use of this makefile.