Fix Constant_Dynamic index for ldc2_w bytecode #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanHeidinga
reviewed
Oct 17, 2018
|
Nice find @fengxue-IS ! |
|
Using this PR to test the osx pull request builds |
|
Jenkins test sanity osx jdk11 |
|
osx PR build failed due to |
fengxue-IS
force-pushed
the
condyWriterFix
branch
from
15cbd79 to
fcabc11
Compare
Since Constant_Dynamic only requires a single slot in constant pool, the index referenced by bytecode doesn't need to be adjusted during classfile creation. Signed-off-by: Jack Lu <[email protected]>
fengxue-IS
force-pushed
the
condyWriterFix
branch
from
fcabc11 to
58662ae
Compare
|
Jenkins test sanity zlinux jdk11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Constant_Dynamic only requires a single slot in constant pool,
the index referenced by bytecode doesn't need to be adjusted during
classfile creation.
Signed-off-by: Jack Lu [email protected]