Remove check for free memory return to OS in Softmx test #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An expectation of test that decommited heap memory is going to be returned to OS is not reliable. It is a source of intermittent failures. From another side ibmMemoryMBean.getHeapMemoryUsage().getCommitted() always returns true amount of commited memory. So the main goal of the test to verify -Xsoftmx functionality. Signed-off-by: Dmitri Pivkine <[email protected]>
|
I know this is a little bit confusing that this is a part of testDisclaimMemoryEffects_GC_Test and I removed Disclaimed Memory return check. Well if we treat "Disclaim Memory" as a Xsoftmx functionality check it makes sense. We can not control actual return memory to OS reliably so would be always a possibility of intermittent failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An expectation of test that decommited heap memory is going to be
returned to OS is not reliable. It is a source of intermittent failures.
From another side ibmMemoryMBean.getHeapMemoryUsage().getCommitted()
always returns true amount of commited memory. So the main goal of the
test to verify -Xsoftmx functionality.
fixes #1470
Signed-off-by: Dmitri Pivkine [email protected]