Align heap for GS if necessary only #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature would be activated in OMR eclipse-omr/omr#3067 |
amicic
reviewed
Oct 15, 2018
| @@ -677,45 +677,50 @@ MM_CollectorLanguageInterfaceImpl::scavenger_switchConcurrentForThread(MM_Enviro | |||
|
|
|||
| if (_extensions->scavenger->isConcurrentInProgress()) { | |||
| Assert_MM_true(NULL != _extensions->scavenger); | |||
There was a problem hiding this comment.
while changing the file, please use _extensions->isConcurrentScavengerInProgress() and remove the assert
There was a problem hiding this comment.
isConcurrentInProgress() should rely be private but you don't need to change it now
|
Jenkins test sanity zLinux jdk8 |
Usage of GS requires special heap alignments. Usage of Software Barriers does not have such restrictions as well as calls of j9gs_enable()/j9gs_disable() Signed-off-by: Dmitri Pivkine <[email protected]>
amicic
approved these changes
Oct 15, 2018
|
Jenkins test sanity zLinux jdk8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of GS requires special heap alignments. Usage of Software Barriers
does not have such restrictions as well as calls of
j9gs_enable()/j9gs_disable()
Signed-off-by: Dmitri Pivkine [email protected]