Use properties file to control whether pointer classes are generated #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both pointer and structure classes must be included in j9ddr.jar to continue supporting debug extensions (which must be compiled using j9ddr.jar). Signed-off-by: Keith W. Campbell <[email protected]>
|
jenkins test sanity zlinux |
pshipton
approved these changes
Oct 9, 2018
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both pointer and structure classes must be included in j9ddr.jar to continue supporting debug extensions (which must be compiled using j9ddr.jar).
With this change,
J9DDRClassLoaderwill use pointer classes in j9ddr.jar unless it containspointers/generated/dynamic.propertieswhich definesgenerate.pointerswith the valuetrue, in which case, pointer classes will be generated dynamically based on the blob in the related core file.The related pull requests will be updated accordingly:
ibmruntimes/openj9-openjdk-jdk8#117
ibmruntimes/openj9-openjdk-jdk11#28