Modify the path to libjava to include "../" #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test sanity plinux,xlinux jdk8 |
|
jenkins test sanity zlinux,win jdk11 |
|
jenkins test sanity aix jdk11 |
|
@DanHeidinga fyi the failures |
|
Thanks. Looking |
DanHeidinga
changed the title
J9PORT_SLOPEN_OPEN_EXECUTABLE when opening the executableJ9PORT_SLOPEN_OPEN_EXECUTABLE when opening the executable
Mac OSX build requires this to initialize correctly when building JDK11. The directory layout for a JDK11 build is jdk/lib/[compressedrefs|default]. Since the library doing the lookup is in the compressedrefs or default directory, using ../java to lookup libjava is the correct path. issue: eclipse-openj9#36 Signed-off-by: Dan Heidinga <[email protected]>
DanHeidinga
force-pushed
the
djh/mac_exec
branch
from
00a2c29 to
1ff2b4e
Compare
|
jenkins test sanity zlinux,win,aix,xlinux jdk11 |
DanHeidinga
changed the title
J9PORT_SLOPEN_OPEN_EXECUTABLE when opening the executable
gacholio
approved these changes
Oct 10, 2018
|
WIP needs to be removed before merge. |
pshipton
approved these changes
Oct 10, 2018
pshipton
changed the title
|
I believe the travis failure is caused by #3204 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac OSX build requires this to initialize correctly when building JDK11.
The directory layout for a JDK11 build is jdk/lib/[compressedrefs|default].
Since the library doing the lookup is in the compressedrefs or default
directory, using ../java to lookup libjava is the correct path.
issue: #36
Signed-off-by: Dan Heidinga [email protected]