Pass Artifactory details to Test jobs #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Minimally we need to pass ARTIFACTORY_SERVER to the test jobs in order for them to upload test artifacts to Artifactory. - Write the rest of the Artifactory variables to the build env for future use. - We have the option to pass more of these variables in the future if we wish. See - adoptium/aqa-tests#591 - adoptium/aqa-tests#561 - eclipse-openj9#1017 [skip ci] Signed-off-by: Adam Brousseau <[email protected]>
|
@jdekonin and @smlambert for review |
jdekonin
reviewed
Oct 3, 2018
| ARTIFACTORY_SERVER = VARIABLES.artifactory_server | ||
| ARTIFACTORY_REPO = VARIABLES.artifactory_repo | ||
| env.ARTIFACTORY_SERVER = VARIABLES.artifactory_server | ||
| env.ARTIFACTORY_REPO = VARIABLES.artifactory_repo |
There was a problem hiding this comment.
Because these are set in the Build job, in order to sniff it in the upstream pipeline it has to be written to the environment. The only one we need for this change is the server but the test code will accept repo, num artifacts as well. See PR in description.
jdekonin
approved these changes
Oct 3, 2018
smlambert
approved these changes
Oct 3, 2018
|
Pretty sure this broke the builds. Adding Previously this would not print because we didn't enter the |
AdamBrousseau
added a commit
to AdamBrousseau/openj9
that referenced
this pull request
Oct 3, 2018
[skip ci] Fixes eclipse-openj9#3114 Signed-off-by: Adam Brousseau <[email protected]>
AdamBrousseau
added a commit
to AdamBrousseau/openj9
that referenced
this pull request
Oct 3, 2018
eclipse-openj9#3129 eclipse-openj9#3114 [skip ci] Signed-off-by: Adam Brousseau <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to the test jobs in order for them to upload
test artifacts to Artifactory.
to the build env for future use.
variables in the future if we wish.
See
[skip ci]
Signed-off-by: Adam Brousseau [email protected]