Handle error thrown by nestmate visibility check #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengxue-IS
changed the title
|
@gacholio can you please take a look? |
gacholio
reviewed
Oct 2, 2018
|
Has this behaviour been verified against the RI? |
gacholio
reviewed
Oct 2, 2018
`checkVisibility` used to only return error code, Nestmates imposed extra checks on the nesthost class which may throw errors. This change addresses potential incorrect exception handling that sets wrong type of exception during method lookup. Signed-off-by: Jack Lu <[email protected]>
fengxue-IS
force-pushed
the
visibleCheck
branch
from
284f65d to
efb314f
Compare
|
This fixed a JDK11 nestmates test failure to match RI behaviour |
gacholio
approved these changes
Oct 2, 2018
|
jenkins test sanity zlinux jdk11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkVisibilityused to only return error code, Nestmates imposedextra checks on the nesthost class which may throw errors.
This change addresses potential incorrect exception handling that
sets wrong type of exception during method lookup.
Signed-off-by: Jack Lu [email protected]