Update JIT makefiles to allow building on OSX #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nazim Uddin Bhuiyan <[email protected]>
Also prevent unsupported options from being used for the linker. Signed-off-by: Nazim Uddin Bhuiyan <[email protected]>
The variables LIBPREFIX and SOSUFF were not being used in the rules.mk file used by linux and OSX to generate the name of the JIT shared library. It is now necessary to make use of these available variables, given that the suffix would differ based on the platform. Signed-off-by: Nazim Uddin Bhuiyan <[email protected]>
With the x86 JIT assembly code moving towards using the NASM Assembler, these rules are needed to build the nasm files as more x86 OS-es make use of NASM. Signed-off-by: Nazim Uddin Bhuiyan <[email protected]>
|
Jenkins test sanity |
0xdaryl
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains all OSX-specific makefile changes needed to successfully build the JIT on OSX, with the exception updating the files list to use .nasm and .pnasm assembly files on OSX, which will be a part of #2864 .
Issue: #36