Modify testConfig to add a check for guarded storage support #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sophia-guo could you please review? |
sophia-guo
approved these changes
Sep 24, 2018
Added a check to configure.pl to check for zOS z14 or higher hardware to enable concurrent scavenger tests. Signed-off-by: Evgenia Badyanova <[email protected]>
fjeremic
reviewed
Sep 24, 2018
| my $hardware=`uname -m`; | ||
| if ($hardware >= $ZOSR14) { | ||
| $capability_Hash{guardedstorage} = 1; | ||
| } |
There was a problem hiding this comment.
This isn't necessarily true. We can very well be on a z14 but guarded storage disabled due to missing OS support. I guess it's a decent starting point though but we ought to be checking the port library or something for these kinds of queries. This shouldn't block the merge of this PR but something to think about for the future.
|
While we do not have this hardware in the open, will run a limited PR test to ensure script runs. |
|
Jenkins test sanity zlinux jdk11 |
|
jenkins test extended zlinux jdk11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to configure.pl to check for zOS z14 or higher hardware to
enable concurrent scavenger tests.