CMake: Bring up plinux #2566
CMake: Bring up plinux #2566
Conversation
| set(J9VM_THR_LOCK_NURSERY ON CACHE BOOL "") | ||
| set(J9VM_THR_LOCK_RESERVATION ON CACHE BOOL "") | ||
| set(J9VM_THR_PREEMPTIVE ON CACHE BOOL "") | ||
| set(J9VM_THR_SMART_DEFLATION ON CACHE BOOL "") |
There was a problem hiding this comment.
A lot of these flags are likely identical across all platforms. Is there a way to make a common cache file that platforms can share?
We recently went down the copy/paste route in our jenkins build configs and have regretted not commoning the code immediately. It's now lots of work to undo the decision to duplicate.
I'd like to avoid that here if we can.
There was a problem hiding this comment.
If we want to change down the line, it would be a trivial change. My thinking was that once I have all (or nearly all) the platforms up it would be easier to find the common options, and just make those the defaults. However, I'm happy to do some of that refactoring now
There was a problem hiding this comment.
My preference is to do some of that work upfront. Too easy to live with the cut/paste forever otherwise.
dnakamura
force-pushed
the
cmake_plinux
branch
from
22ae3fe to
2607061
Compare
|
@dnakamura please take a look at the travis failure |
|
I believe I have the travis builds fixed, however now they are hitting the max job length and being killed. |
|
@dnakamura pls rebase. Not sure if the travis failure is relevant, can see how it does after rebase. |
Signed-off-by: Devin Nakamura <[email protected]>
dnakamura
force-pushed
the
cmake_plinux
branch
from
2607061 to
1c16335
Compare
|
@pshipton rebased and good to go |
Signed-off-by: Devin Nakamura [email protected]