Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error with legacy DDR tools #11150

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Conversation

keithc-ca
Copy link
Contributor

The legacy DDR tooling apparently doesn't support use of (nested) enum literals.

@keithc-ca keithc-ca requested a review from tajila November 11, 2020 14:19
@keithc-ca
Copy link
Contributor Author

@tajila This is close to what you had originally proposed - sorry for the churn.

@fjeremic
Copy link
Contributor

fjeremic commented Nov 11, 2020

Curious, what is the legacy DDR tooling used for? When did we switch to the non-legacy version? Would love to understand the history of the tool.

@pshipton
Copy link
Member

jenkins compile zlinux jdk8

@keithc-ca
Copy link
Contributor Author

IBM internal builds of Java 8 use the same (legacy) tools they always have. See #378 for more information about the tools used externally and in other versions.

@pshipton
Copy link
Member

I think #11144 broke aix jdk15 compiles as well.
https://ci.eclipse.org/openj9/job/Build_JDK15_ppc64_aix_Nightly/104

22:49:07  /home/jenkins/workspace/Build_JDK15_ppc64_aix_Nightly/openj9/debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/j9/ObjectFieldInfo.java:27: error: cannot find symbol
22:49:07  import static com.ibm.j9ddr.vm29.structure.ObjectFieldInfo.OBJECT_SIZE_INCREMENT_IN_BYTES;
22:49:07  ^
22:49:07    symbol:   static OBJECT_SIZE_INCREMENT_IN_BYTES
22:49:07    location: class ObjectFieldInfo

jenkins compile aix jdk15

@pshipton
Copy link
Member

@keithc-ca pls see the build failure.

Signed-off-by: Keith W. Campbell <[email protected]>
@keithc-ca
Copy link
Contributor Author

Fixed typo in reference to SIZEOF field.

@keithc-ca
Copy link
Contributor Author

Jenkins compile zlinux jdk8

@keithc-ca
Copy link
Contributor Author

Jenkins compile aix jdk15

@pshipton
Copy link
Member

The builds have passed, although jenkins was restarted and AIX isn't finished uploading results.

@gacholio gacholio merged commit 8898734 into eclipse-openj9:master Nov 11, 2020
@keithc-ca keithc-ca deleted the ddr branch November 11, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants