Fix handling of literals of anonymous enum types #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix * promote _enumMembers from ClassType to NamespaceUDT * collect literals of a nested anonymous enum in enclosing namespace Cleanup * change signature of Type::getSymbolKindName() * check that IO operations are successful * remove unnecessary #include directives * remove useless method TypedefUDT::insertUnique() * manage printing type header in JavaSupersetGenerator * extract common code for visiting class and union types Addition * add TypePrinter for debugging (currently disabled) Signed-off-by: Keith W. Campbell <[email protected]>
|
@genie-omr build all |
1 similar comment
|
@genie-omr build all |
| TypePrinter::printIndent() const | ||
| { | ||
| for (int32_t i = _indent; i > 0; --i) { | ||
| printf(" "); |
There was a problem hiding this comment.
Only question is should we be using the PortLibrary tty_printf instead of printf in this class and ddrgen.cpp?
There was a problem hiding this comment.
Perhaps that would be better, but this is only a debugging aid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Cleanup
Addition
This should be the final OMR change required to enable eclipse-openj9/openj9#378 on Linux.