Replace CARD_SIZE & CARD_SIZE_SHIFT with macros #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddrgen associates literals of anonymous enums with the enclosing scope. As there is no such scope in the case of CARD_SIZE & CARD_SIZE_SHIFT these literals are not captured. As macros they will be included in the superset & blob. Signed-off-by: Keith W. Campbell <[email protected]>
|
@genie-omr build all zos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ddrgen associates literals of anonymous enums with the
enclosing scope. As there is no such scope in the case of
CARD_SIZE & CARD_SIZE_SHIFT these literals are not captured.
As macros they will be included in the superset & blob.
In support of eclipse-openj9/openj9#378.