Preparations for use of ddrgen #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In support of openj9#378 * correct references to getmacros script * add missing ddr_namespace annotations * use J9HASH_TABLE_AVL_TREE_TAG_BIT instead of hard-coded constant * ignore objs directory Signed-off-by: Keith W. Campbell <[email protected]>
|
Cross linking the OpenJ9 issue eclipse-openj9/openj9#378. |
|
|
||
| all: check-vars | ||
| ./tools/ddrgen/src/macros/getMacros.sh $(abs_srcroot) | ||
| bash $(top_srcdir)/ddr/tools/getmacros $(abs_srcroot) |
There was a problem hiding this comment.
should we be relying on bash? Can we not just use sh? I know there are sometimes issues with bash on AIX and zOS.
There was a problem hiding this comment.
getmacros begins with
#!/bin/bashand I think it does depend on features in bash that are not in sh.
There was a problem hiding this comment.
makes sense then to use bash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparations for use of ddrgen in support of openj9#378