Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for DDR #1222

Merged
merged 136 commits into from
Aug 16, 2017
Merged

Fixes for DDR #1222

merged 136 commits into from
Aug 16, 2017

Conversation

youngar
Copy link
Contributor

@youngar youngar commented Jun 6, 2017 •
edited
Loading

Continuing from #1014.

This PR introduces the following changes:

  • Code reorganization
  • Cmake compilation support
  • Two phase superset generation:
    • generate IL for all compilation units
    • combine generated IL into one cohesive IL
  • Many small improvements to better support IL generation for different platforms and compilers
  • Building DDR in our CI

youngar and others added 30 commits April 12, 2017 20:38
@youngar
Make the getMacros script executable
deda656 
Signed-off-by: Andrew Young <[email protected]>
@youngar
Fix fetching the compilationDirectory attribute
c751347 
We currently are missing a call to dwarf_attr() to fetch the
DW_AT_comp_dir attribute.  This call was there previously, but lost in
change 055c3bf.  This means that attr
will always be NULL.

On my Linux machine, dwarf_formatstring() will segfault when passed attr
with a value of NULL.  The manual states that dwarf_formatstring() will
return DW_DLE_ARGUMENT if "Either of arguments or ret was NULL", but
also states "The form of argument attr must be one of DW_FORM_string or
DW_FORM_strp".

Signed-off-by: Andrew Young <[email protected]>
@youngar
Use using std::make_pair
8a4d479 
Signed-off-by: Andrew Young <[email protected]>
@youngar
Properly handle the missing dwarf attribute
ef7592d 
dwarf_hasattr() only returns DW_DLV_ERROR in the case of an internal
dwarf library error, not in the case of no attribute present. If the Die
has no compilation directory, hasAttr will be false. The correct thing
to do here is to check the value of hasAttr.

Signed-off-by: Andrew Young <[email protected]>
@youngar
Run ddrgen in the x86-64 travis builds
7b89c5b 
Signed-off-by: Andrew Young <[email protected]>
@youngar
Add ddrgen instructions
99075b4 
Signed-off-by: Andrew Young <[email protected]>
@rwy7
Remove duplicate static definitions
302fd95 
Causing a compile failure on OSX.

Signed-off-by: Robert Young <[email protected]>
@rwy7
Reorganize IR sources
da33fba 
Signed-off-by: Robert Young <[email protected]>
@rwy7
Reorganize pdb scanner headers
882645c 
Signed-off-by: Robert Young <[email protected]>
@rwy7
Reorg macro headers
f6354e3 
Signed-off-by: Robert Young <[email protected]>
@rwy7
Reorg scanner headers
a436781 
Signed-off-by: Robert Young <[email protected]>
@rwy7
Fix busted executable ignores
85ef69e 
Signed-off-by: Robert Young <[email protected]>
@rwy7
Move ddr headers to new home
8189739 
Signed-off-by: Robert Young <[email protected]>
@rwy7
Move DDR to a top-level project
4ef2bca 
Build DDR as part of OMR. Use standard OMR configuration.
Move the DDR libraries from src to lib/$libname
Move the DDR tools from src to tools/$toolname
Move headers to include/ddr/
include headers by their full path "ddr/*.hpp"
Capitalize Makefile names

Signed-off-by: Robert Young <[email protected]>
@rwy7
Add ddr to main_targets
58604b1 
Signed-off-by: Robert Young <[email protected]>
@rwy7
Fix a few missing include prefixes
1a2f05d 
Signed-off-by: Robert Young <[email protected]>
@rwy7
Clean up ddr targets
176dbe3 
Signed-off-by: Robert Young <[email protected]>
@rwy7
Add missing cxx flags to ddr test
79e7acd 
Signed-off-by: Robert Young <[email protected]>
@rwy7
Add ddr- prefix to DDR libraries
e2c1038 
Signed-off-by: Robert Young <[email protected]>
@rwy7
Update DDR doc with new paths
0c9a654 
Signed-off-by: Robert Young <[email protected]>
@rwy7
Define DDR target properly
5c1980c 
Signed-off-by: Robert Young <[email protected]>
@youngar
Re-add DDR expected output
2b2f992 
Also update testing instructions to reflect the current location.

Signed-off-by: Andrew Young <[email protected]>
@youngar
Fix DDR makefile target list
1cca4d6 
Signed-off-by: Andrew Young <[email protected]>
@youngar
Print error message if ddrgen macrolist is missing
e8e2a1a 
Signed-off-by: Andrew Young <[email protected]>
@youngar
Do not default to using test macrolist in ddrgen
ccd7d39 
Signed-off-by: Andrew Young <[email protected]>
@youngar
Trap ctrl-c in getmacros to clean up before exit
4555bb4 
Signed-off-by: Andrew Young <[email protected]>
@youngar
Update ddr.md copyright date
ecce2f4 
Signed-off-by: Andrew Young <[email protected]>
@youngar
Merge remote-tracking branch 'eclipse/master'
b1c121c 
Signed-off-by: Andrew Young <[email protected]>
@rwy7
Compile with c++0x, 11 is too new
68cbba9 
Signed-off-by: Robert Young <[email protected]>
@jason-hall
Add improved blacklist input option for both scanners
33606f9 
Signed-off-by: Jason Hall <[email protected]>
rwy7 and others added 4 commits August 1, 2017 12:54
rwy7
rwy7 reviewed Aug 1, 2017
View reviewed changes
ddr/include/ddr/ir/Modifiers.hpp
@@ -19,7 +19,7 @@
#ifndef MODIFIERS_HPP
#define MODIFIERS_HPP

#include <string>
#include "ddr/std/string.hpp"
#include <vector>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does vector also need a compatibility header?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of a reason it would

rwy7
rwy7 reviewed Aug 1, 2017
View reviewed changes
ddr/include/ddr/ir/Type.hpp Outdated
@@ -22,7 +22,7 @@
#include "ddr/config.hpp"

#include <set>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And set too?

@youngar youngar changed the title WIP: Fixes for DDR Fixes for DDR Aug 2, 2017
@rwy7
Add back ddrgen phony target
f11de21 
Signed-off-by: Robert Young <[email protected]>
@youngar youngar changed the title Fixes for DDR WIP: Fixes for DDR Aug 2, 2017
@youngar
Copy link
Contributor Author

youngar commented Aug 4, 2017

I have created a CQ and uploaded a patch for this change. For those who are members of the project, the CQ is here: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=13962. I will try to keep this PR updated with the CQ status.

@youngar youngar changed the title WIP: Fixes for DDR Fixes for DDR Aug 5, 2017
@youngar
Copy link
Contributor Author

youngar commented Aug 11, 2017

This CQ has been approved!

@youngar youngar merged commit ca86d8c into eclipse-omr:master Aug 16, 2017
@DanHeidinga DanHeidinga mentioned this pull request Oct 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-hall jason-hall jason-hall left review comments

@rwy7 rwy7 rwy7 left review comments

Assignees

@charliegracie charliegracie

Labels
comp:diagnostic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@youngar @mstoodle @rwy7 @jason-hall @charliegracie