Migrate to SLF4J + Logback and Gson from Maven-Central instead of Orbit #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
|
I also created eclipse-platform/eclipse.platform.releng.aggregator#588 to coordinate the logback migration through the whole Eclipse Platform/IDE. |
HannesWell
force-pushed
the
logbackFromMaven
branch
from
4d0d7f6 to
a8402a8
Compare
HannesWell
force-pushed
the
logbackFromMaven
branch
from
a8402a8 to
bbdb7c0
Compare
|
/request-license-review |
License review requests:
After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status. Workflow run (with attached summary files): |
|
I wonder why those Eclipse artifacts are not inherently vetted? is there an issue with the lookup logic? |
HannesWell
force-pushed
the
logbackFromMaven
branch
from
bbdb7c0 to
10a1f2f
Compare
Merged
HannesWell
force-pushed
the
logbackFromMaven
branch
2 times, most recently
from
0097521 to
356dc2d
Compare
HannesWell
force-pushed
the
logbackFromMaven
branch
5 times, most recently
from
c2f2a2c to
c8cce60
Compare
Build against slf4j and logback from Maven-Central and include them into M2E's p2 repo to contribute it to SimRel. Furthermore guard against adding multiple slf4j binding to the classpath, when launching the embedded Maven-Runtime, by explicitly not adding dependencies of the slf4j bundles. Fixes eclipse-m2e#738
HannesWell
force-pushed
the
logbackFromMaven
branch
from
c8cce60 to
365b0a5
Compare
This was referenced Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build against slf4j and logback from Maven-Central and include them into m2e's p2 repo to contribute it to SimRel.
The version at Maven-Central is more recent and not jar-signed by the Eclipse-Foundation which helps to address the difficulties encountered in #926.
Logback from Orbit uses a different approach to wire
org.slf4j.apiandch.qos.logback.classic(both from Orbit) . Besides logback-core and classic it is split additionally into a third fragmentch.qos.logback.slf4jwhose host isorg.slf4j.api(from Orbit) and that contains and exports theorg.slf4j.implpackage of logback-classic and imports packages from the latter. This way effectivelyorg.slf4j.apirequiresch.qos.logback.classic.In order to now have two slf4j bindings on the classpath of Maven-build launched from within the IDE and thus to avoid corresponding warnings, I have adjusted the code in
MavenEmbeddedRuntimeto not pull in dependencies of slf4j (with old and new bundle name).Fixes #738