Use p2.inf to generate installable maven runtimes and add release note #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
force-pushed
the
add_p2_inf_for_runtime_units
branch
from
a727dfd to
ab87695
Compare
HannesWell
approved these changes
Jun 25, 2023
There was a problem hiding this comment.
I have not understand this in depth, but what I see/understand sounds reasonable to me.
For clarification, this adds two IUs to the m2e p2-repo, where each requires the m2e.maven.runtime in a specific minor version range, so that one can install that artificial units that pull in the actual bundles?
org.eclipse.m2e.repository/p2.inf
Outdated
| units.0.update.id = org.eclipse.m2e.maven.runtime.38.iu | ||
| units.0.update.range = [1.0.0,1.0.0] | ||
|
|
||
| # Define IU for Maven 3.8 |
There was a problem hiding this comment.
Suggested change
| # Define IU for Maven 3.8 | |
| # Define IU for Maven 3.9 |
This adds two new units that can be used to install additional runtimes into m2eclipse and a release note that explains how to use this.
laeubi
force-pushed
the
add_p2_inf_for_runtime_units
branch
from
ab87695 to
580067d
Compare
yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new units that can be used to install additional runtimes into m2eclipse and a release note that explains how to use this.