Refactor UpdateClassPathJob to provide a more general interface #1267
Merged
fbricon merged 6 commits intoeclipse-jdtls:masterfrom Nov 25, 2019
Merged
Refactor UpdateClassPathJob to provide a more general interface #1267fbricon merged 6 commits intoeclipse-jdtls:masterfrom
fbricon merged 6 commits intoeclipse-jdtls:masterfrom
Conversation
Contributor
|
Please add some unit tests. |
Contributor
|
add to whitelist |
Contributor
|
test this please |
* Remove fs-related logic * Restruct the signature to accept a map of <binary, source> pairs Signed-off-by: Vigilans <vigilans@foxmail.com>
…de, exclude, sources> tuple Signed-off-by: Vigilans <vigilans@foxmail.com>
Signed-off-by: Vigilans <vigilans@foxmail.com>
Signed-off-by: Vigilans <vigilans@foxmail.com>
Signed-off-by: Vigilans <vigilans@foxmail.com>
Vigilans
force-pushed
the
vigilans/update-classpath
branch
3 times, most recently
from
08c09dd to
0518b27
Compare
Signed-off-by: Vigilans <vigilans@foxmail.com>
Vigilans
force-pushed
the
vigilans/update-classpath
branch
from
0518b27 to
9300730
Compare
Contributor
Author
3 tasks
Contributor
|
Thanks @Vigilans! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1257