Recommend variable name for Extracted Local Variable Refactoring when the extracted expression is a method invocation #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelll123
force-pushed
the
improve-name-recommendation-on-extracted-method-invocation-expression
branch
from
5953e8d to
1ca69f1
Compare
Michaelll123
force-pushed
the
improve-name-recommendation-on-extracted-method-invocation-expression
branch
from
c9051a6 to
7a1bd85
Compare
Michaelll123
force-pushed
the
improve-name-recommendation-on-extracted-method-invocation-expression
branch
2 times, most recently
from
9b0bf00 to
a1afc2a
Compare
|
Hi @Michaelll123 Please rename the tests as they now conflict with tests you just added and do a rebase (not merge) from origin/master so the patch will build. I'll try to review this for 4.30 M1 if you can get this turned around in time. |
will do today. |
Michaelll123
added a commit
to Michaelll123/eclipse.jdt.ui
that referenced
this pull request
Sep 22, 2023
… the extracted expression is a method invocation eclipse-jdt#685
Michaelll123
force-pushed
the
improve-name-recommendation-on-extracted-method-invocation-expression
branch
from
a1afc2a to
ed3e405
Compare
Michaelll123
added a commit
to Michaelll123/eclipse.jdt.ui
that referenced
this pull request
Sep 22, 2023
… the extracted expression is a method invocation eclipse-jdt#685
Michaelll123
added a commit
to Michaelll123/eclipse.jdt.ui
that referenced
this pull request
Sep 22, 2023
… the extracted expression is a method invocation eclipse-jdt#685
|
/rebase |
… the extracted expression is a method invocation eclipse-jdt#685
… the extracted expression is a method invocation eclipse-jdt#685
… the extracted expression is a method invocation eclipse-jdt#685
github-actions
bot
force-pushed
the
improve-name-recommendation-on-extracted-method-invocation-expression
branch
from
196d52e to
6f59625
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
see issue #684
How to test
run test161.
Author checklist