Support Junit5 parallel test execution through RemoteTestRunner (#378) #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pse-jdt#378) synchronized test failure notifications with multiple socket writes Signed-off-by: Wladimir Hofmann <[email protected]>
|
manual test, logging the RemoteTestRunner output before - failure messages/traces of both tests are mixed up: fixed - failure messages/traces of both tests are correctly sent sequentially: |
|
Thanks @fladdimir |
|
@jjohnstn Thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
synchronized test failure notifications with multiple socket writes to prevent mixed-up output caused by calls from concurrent threads (resolves #378)
How to test
(hopefully) by running parallel tests, e.g. in console mode
Author checklist