Adapted the client to use new Browser API #1597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contribution alloows the client to utilize the new API from SWT Browser to check if the url is the custom text url of the browser. Contributes to eclipse-jdt#213
amartya4256
force-pushed
the
browser_client_fix
branch
from
80fbdee
to
1d634f0
Compare
|
Closing beacause the API change is not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The contribution allows the client to utilize the new API from SWT Browser to check if the url is the custom text url of the browser.
Contributes to #213
Must be merged only after eclipse-platform/eclipse.platform.swt#1409 & eclipse-platform/eclipse.platform.ui#2211 have been merged
How to test
Author checklist