remove unnecessary casts #1473
Merged
remove unnecessary casts #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephan-herrmann
pushed a commit
to stephan-herrmann/eclipse.jdt.ui
that referenced
this pull request
Jun 20, 2024
stephan-herrmann
force-pushed
the
removeCasts
branch
from
d78f3be
to
7212636
Compare
stephan-herrmann
force-pushed
the
removeCasts
branch
from
7212636
to
72a38ad
Compare
|
Hi @stephan-herrmann Sorry I restarted just after you did. I'll keep trying to get this rebuilt. I have had issues lately with the UI build taking too much time and being aborted. |
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When eclipse-jdt/eclipse.jdt.core#2471 is merged, ecj will signal more casts as unnecessary.
With this PR I suggest to remove affected casts before new errors/warnings will show up in the build.