remove recursion from VMInputStream #2816
Open
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you give numbers for this overhead? |
|
I did some testing. If the build is successful no recursive calls happen. Only if something is written to the |
What's wrong with that? When you said "overhead" I was expecting some time measurements... a recursive call is not overhead per se. |
|
I agree. I was also expecting different results. I got here in the first place due to a exception with a large stacktrace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Currently
VMInputStreamuses recursion to retry reads in theint read()method. I replaced the recursive call with a while loop. This removes unnecessary overhead while running tests.How to test
This doesn't change any behavior.
Author checklist