A flag to resolve populating index using ASTParser #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2024
jjohnstn
requested changes
Jul 30, 2024
| @@ -19,7 +19,7 @@ | |||
| import org.eclipse.jdt.core.dom.CompilationUnit; | |||
|
|
|||
| public class ASTHolderCUInfo extends CompilationUnitElementInfo { | |||
| int astLevel; | |||
| public int astLevel; | |||
There was a problem hiding this comment.
Probably better to introduce a public getter method.
org.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/SourceIndexer.java
Show resolved
Hide resolved
org.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/SourceIndexer.java
Outdated
Show resolved
Hide resolved
...eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/DOMToIndexVisitor.java
Show resolved
Hide resolved
mickaelistria
force-pushed
the
indexer-astParser
branch
2 times, most recently
from
846f8cd
to
3e5350d
Compare
|
I'm converting as a draft as one of the remaining TODO is critical. |
Introduce an alternative strategy to popular index from source file by building and visiting their DOM using ASTParser. This allows to make code a bit higher-level than ECJ, and allow to leverage recent changes to use alternative strategy to get DOM too. A system property SourceIndexer.DOM_BASED_INDEXER acts as a flag which when "true" will enable this DOM-strategy in place of direct ECJ parsing.
mickaelistria
force-pushed
the
indexer-astParser
branch
from
3e5350d
to
62c30c4
Compare
|
With latest version of everything, I couldn't reproduce the issue that triggered to commenting out the indexDocumentFromDOM in indexResolveDocument. So I think this is now ready for review. |
jjohnstn
approved these changes
Oct 18, 2024
jjohnstn
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Introduce a SourceIndexer.DOM_BASED_INDEXER flag which instead of using the ECJ-derived parser uses ASTParser to create a DOM and then crawls this DOM to populate index.
This has the benefit of:
How to test
Author checklist