Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#15] Use only one config file for every platform #86

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Jan 15, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Closes #15

@elfenpiff elfenpiff self-assigned this Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (891ae9b) 78.00% compared to head (135251b) 78.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   78.00%   78.00%           
=======================================
  Files         172      172           
  Lines       18778    18790   +12     
=======================================
+ Hits        14647    14658   +11     
- Misses       4131     4132    +1     
Files Coverage Δ
iceoryx2/src/config.rs 69.64% <87.50%> (+2.31%) ⬆️
iceoryx2/src/service/config_scheme.rs 91.30% <84.61%> (+0.12%) ⬆️

@elfenpiff elfenpiff force-pushed the iox2-15-same-default-config-file branch from 92b19ba to 135251b Compare January 15, 2024 02:31
config/README.md Show resolved Hide resolved
config/iceoryx2.toml Show resolved Hide resolved
@elfenpiff elfenpiff merged commit 4fae122 into eclipse-iceoryx:main Jan 16, 2024
21 of 23 checks passed
@elfenpiff elfenpiff deleted the iox2-15-same-default-config-file branch January 16, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same default config file for every platform.
2 participants