-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#69] port traits #73
Conversation
f2934a0
to
f8a4bbd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 78.00% 77.97% -0.04%
==========================================
Files 172 177 +5
Lines 18795 18789 -6
==========================================
- Hits 14661 14650 -11
- Misses 4134 4139 +5
|
f8a4bbd
to
8cdab5b
Compare
af4b5f3
to
5bb4e93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for leaving the PR for so long. Looks good. Basically just a few naming proposals. Can also be merged as is once the branch is rebased to main.
…ple originated from same Publisher
…dependent of SubscriberImpl specific generic arguments
5bb4e93
to
162660f
Compare
…to verify multi year copyrights
c8c5ca9
to
82fbb5f
Compare
} | ||
|
||
/// Allows loaning of uninitialized shared memory that can be used for storing the payload of the message. | ||
pub trait UninitLoan<MessageType: Debug> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed that the words from the trait are reversed compared to the function, UninitLoan <-> loan_uninit, while they are not in other traits, e.g. SendCopy <-> send_copy
Notes for Reviewer
$PORTNAME$_impl.rs
and renamedSample
&SampleMut
files were moved to$SAMPLE$_impl.rs
Listener
,Notifier
,Publisher
,PublisherLoan
,Subscriber
,Sample
,SampleMut
,UninitializedSample
were introducedPre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.
Closes #69
Closes #74