-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#349] Add remaining cargo feature flags to bazel #479
Merged
elBoberido
merged 10 commits into
eclipse-iceoryx:main
from
elBoberido:iox2-349-enable-all-cargo-feature-flags-on-bazel
Oct 18, 2024
Merged
[#349] Add remaining cargo feature flags to bazel #479
elBoberido
merged 10 commits into
eclipse-iceoryx:main
from
elBoberido:iox2-349-enable-all-cargo-feature-flags-on-bazel
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
=======================================
Coverage 78.93% 78.94%
=======================================
Files 198 198
Lines 23627 23627
=======================================
+ Hits 18651 18653 +2
+ Misses 4976 4974 -2 |
elfenpiff
previously approved these changes
Oct 17, 2024
elBoberido
changed the title
[#349] Add remaining cargo feature flags to bazel
[WIP] [#349] Add remaining cargo feature flags to bazel
Oct 17, 2024
@elfenpiff @orecham it seems I was too hasty to add reviewers to the PR. I need to debug why the bazel CI does not like my changes |
elBoberido
force-pushed
the
iox2-349-enable-all-cargo-feature-flags-on-bazel
branch
from
October 17, 2024 20:30
5671a69
to
cad5c29
Compare
elBoberido
force-pushed
the
iox2-349-enable-all-cargo-feature-flags-on-bazel
branch
from
October 17, 2024 22:23
e822468
to
f2735b7
Compare
elBoberido
changed the title
[WIP] [#349] Add remaining cargo feature flags to bazel
[#349] Add remaining cargo feature flags to bazel
Oct 17, 2024
elfenpiff
approved these changes
Oct 18, 2024
elBoberido
deleted the
iox2-349-enable-all-cargo-feature-flags-on-bazel
branch
October 18, 2024 01:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
This PR adds remaining cargo feature flags to bazel.
Additionally, it re-enables running the tests via bazel in the CI and optimizes the CI to not partially rebuild the code for tests by harmonizing the flags passed to
cargo build
andcargo nextest run
Due to reaching the Cirrus CI limit early this month, the Cirrus CI is deactivated and the targets are limited even further.
Finally, a FAQ for iceoryx developers was added.
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #349