Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#349] Add remaining cargo feature flags to bazel #479

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Oct 17, 2024

Notes for Reviewer

This PR adds remaining cargo feature flags to bazel.

Additionally, it re-enables running the tests via bazel in the CI and optimizes the CI to not partially rebuild the code for tests by harmonizing the flags passed to cargo build and cargo nextest run

Due to reaching the Cirrus CI limit early this month, the Cirrus CI is deactivated and the targets are limited even further.

Finally, a FAQ for iceoryx developers was added.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #349

@elBoberido elBoberido self-assigned this Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.94%. Comparing base (a657228) to head (97264ae).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #479   +/-   ##
=======================================
  Coverage   78.93%   78.94%           
=======================================
  Files         198      198           
  Lines       23627    23627           
=======================================
+ Hits        18651    18653    +2     
+ Misses       4976     4974    -2     

see 1 file with indirect coverage changes

elfenpiff
elfenpiff previously approved these changes Oct 17, 2024
@elBoberido elBoberido changed the title [#349] Add remaining cargo feature flags to bazel [WIP] [#349] Add remaining cargo feature flags to bazel Oct 17, 2024
@elBoberido
Copy link
Member Author

@elfenpiff @orecham it seems I was too hasty to add reviewers to the PR. I need to debug why the bazel CI does not like my changes

@elBoberido elBoberido force-pushed the iox2-349-enable-all-cargo-feature-flags-on-bazel branch from 5671a69 to cad5c29 Compare October 17, 2024 20:30
@elBoberido elBoberido force-pushed the iox2-349-enable-all-cargo-feature-flags-on-bazel branch from e822468 to f2735b7 Compare October 17, 2024 22:23
@elBoberido elBoberido changed the title [WIP] [#349] Add remaining cargo feature flags to bazel [#349] Add remaining cargo feature flags to bazel Oct 17, 2024
@elBoberido elBoberido merged commit 4dc37ec into eclipse-iceoryx:main Oct 18, 2024
47 checks passed
@elBoberido elBoberido deleted the iox2-349-enable-all-cargo-feature-flags-on-bazel branch October 18, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants