Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#349] Bazel 6.2 fix and iceoryx update #470

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Oct 16, 2024

Notes for Reviewer

Update to the iceoryx dependency to v2.95.3 tag.

Add a bazel 6.2 fix by moving the feature_dev_permission feature flag to the root BUILD.bazel.

Update bazel documentation.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #349

@elBoberido elBoberido changed the title Iox2 349 bazel 6.2 fix and iceoryx update [#349} Bazel 6.2 fix and iceoryx update Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.93%. Comparing base (cd27eee) to head (984e675).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #470   +/-   ##
=======================================
  Coverage   78.93%   78.93%           
=======================================
  Files         197      197           
  Lines       23637    23637           
=======================================
+ Hits        18657    18658    +1     
+ Misses       4980     4979    -1     

see 1 file with indirect coverage changes

Copy link
Contributor

@xieyuschen xieyuschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the title has a typo though, don't forget to update it.

-[#349} Bazel 6.2 fix and iceoryx update
+[#349] Bazel 6.2 fix and iceoryx update

@elBoberido elBoberido changed the title [#349} Bazel 6.2 fix and iceoryx update [#349] Bazel 6.2 fix and iceoryx update Oct 16, 2024
@elBoberido elBoberido merged commit b930be6 into eclipse-iceoryx:main Oct 16, 2024
54 checks passed
@elBoberido elBoberido deleted the iox2-349-bazel-6.2-fix-and-iceoryx-update branch October 16, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants