Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox2 2 rename crates #26

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Dec 13, 2023

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Relates to #2

@elfenpiff elfenpiff self-assigned this Dec 13, 2023
elBoberido
elBoberido previously approved these changes Dec 13, 2023
@elBoberido elBoberido linked an issue Dec 13, 2023 that may be closed by this pull request
46 tasks
@elBoberido elBoberido removed a link to an issue Dec 13, 2023
46 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #26 (d019d86) into main (86376c3) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   77.90%   77.90%           
=======================================
  Files         172      172           
  Lines       19059    19059           
=======================================
  Hits        14848    14848           
  Misses       4211     4211           
Files Coverage Δ
iceoryx2-bb/posix/src/config.rs 0.00% <ø> (ø)
iceoryx2-bb/posix/src/directory.rs 62.18% <ø> (ø)
iceoryx2-bb/posix/src/shared_memory.rs 81.60% <ø> (ø)
iceoryx2-bb/system-types/src/file_name.rs 56.52% <ø> (ø)
iceoryx2-bb/system-types/src/file_path.rs 85.18% <ø> (ø)
iceoryx2-bb/system-types/src/path.rs 89.00% <100.00%> (ø)
iceoryx2-pal/concurrency-sync/src/barrier.rs 96.77% <ø> (ø)
...yx2-pal/concurrency-sync/src/condition_variable.rs 100.00% <ø> (ø)
iceoryx2-pal/concurrency-sync/src/mutex.rs 94.33% <ø> (ø)
iceoryx2-pal/concurrency-sync/src/rwlock.rs 99.54% <ø> (ø)
... and 1 more

@elfenpiff elfenpiff merged commit 4ae1d6b into eclipse-iceoryx:main Dec 13, 2023
5 of 18 checks passed
@elfenpiff elfenpiff deleted the iox2-2-rename-crates branch December 13, 2023 01:35
@elBoberido elBoberido linked an issue Dec 13, 2023 that may be closed by this pull request
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Source Preparations
3 participants