-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#123] Introduce hash value #128
Merged
elfenpiff
merged 4 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-123-introduce-uuid-type
Feb 21, 2024
Merged
[#123] Introduce hash value #128
elfenpiff
merged 4 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-123-introduce-uuid-type
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 77.38% 77.41% +0.02%
==========================================
Files 181 179 -2
Lines 19599 19682 +83
==========================================
+ Hits 15166 15236 +70
- Misses 4433 4446 +13
|
…contains invalid utf8 characters
elBoberido
reviewed
Feb 20, 2024
elBoberido
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good. One additional test for a failed insertion would be nice.
… - damn you elBoberido
elfenpiff
force-pushed
the
iox2-123-introduce-uuid-type
branch
from
February 21, 2024 22:29
e90228c
to
e7e006e
Compare
elBoberido
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
According to this: https://csrc.nist.gov/glossary/term/hash_value the result of a hash function is a
HashValue
orHashOutput
. I decided to useHashValue
.It is based on the newly introduced
Base64Url
semantic string so that the hash result can always be used for file names.Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.
Closes #123