-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2066 Remove compiler switches for c++17 #2103
Merged
elBoberido
merged 12 commits into
eclipse-iceoryx:master
from
elBoberido:iox-2066-remove-compiler-switches-for-C++17
Nov 20, 2023
Merged
iox-#2066 Remove compiler switches for c++17 #2103
elBoberido
merged 12 commits into
eclipse-iceoryx:master
from
elBoberido:iox-2066-remove-compiler-switches-for-C++17
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elBoberido
added
refactoring
Refactor code without adding features
technical debt
unclean code and design flaws
labels
Nov 18, 2023
elBoberido
changed the title
iox-#2066 Remove compiler switches for c++17
[Based on 2098] iox-#2066 Remove compiler switches for c++17
Nov 18, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2103 +/- ##
=======================================
Coverage 80.29% 80.29%
=======================================
Files 417 417
Lines 16130 16132 +2
Branches 2251 2253 +2
=======================================
+ Hits 12951 12953 +2
Misses 2384 2384
Partials 795 795
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mossmaurice
previously approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
elBoberido
dismissed
mossmaurice’s stale review
November 20, 2023 11:00
The merge-base changed after approval.
…GH' and 'IOX_NO_DISCARD'
elBoberido
force-pushed
the
iox-2066-remove-compiler-switches-for-C++17
branch
from
November 20, 2023 11:03
8108449
to
992fef6
Compare
elBoberido
changed the title
[Based on 2098] iox-#2066 Remove compiler switches for c++17
iox-#2066 Remove compiler switches for c++17
Nov 20, 2023
elBoberido
force-pushed
the
iox-2066-remove-compiler-switches-for-C++17
branch
from
November 20, 2023 12:25
ac7e300
to
b0e68f7
Compare
mossmaurice
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
This PR removes the compiler switches for C++17 and deprecates the
IOX_MAYBE_UNUSED
,IOX_FALLTHROUGH
andIOX_NO_DISCARD
macros in favor of the C++17[[maybe_unused]]
,[[fallthrough]]
and[[no_discard]]
attributes.In addition
std::byte
is used instead ofiox::byte
.Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References