-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2072 Include mqueue.h needs sys/stat.h for mode_t (fixes musl compile) #2073
iox-#2072 Include mqueue.h needs sys/stat.h for mode_t (fixes musl compile) #2073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you did not yet sign the ECA please do it, else the CI prevents to merge the PR. If you already signed it, it might take a day or two to sync.
Thanks for your contribution
Oh, it seems you need to run clang-format or manually sort the includes in alphabetical order |
2f1a8c1
to
e983806
Compare
Codecov Report
@@ Coverage Diff @@
## master #2073 +/- ##
==========================================
+ Coverage 80.09% 80.13% +0.03%
==========================================
Files 416 417 +1
Lines 16026 16055 +29
Branches 2250 2255 +5
==========================================
+ Hits 12836 12865 +29
- Misses 2384 2385 +1
+ Partials 806 805 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
@pseiderer Okay, now the CI is fine. Would you please also add the fixed issue to the changelog? The link is in the PR template. Once that is done we just have to wait for the ECA check to pass |
… (fixes musl compile) As stated in the mq_open man page ([1]) the mqueue.h include needs additional sys/stat.h include for mode_t definition. Fixes musl compile: In file included from .../build/iceoryx-custom/iceoryx_platform/linux/source/mqueue.cpp:17: .../build/iceoryx-custom/iceoryx_platform/linux/include/iceoryx_platform/mqueue.hpp:23:49: error: ‘mode_t’ has not been declared 23 | mqd_t iox_mq_open4(const char* name, int oflag, mode_t mode, struct mq_attr* attr); | ^~~~~~ .../build/iceoryx-custom/iceoryx_platform/linux/source/mqueue.cpp:26:49: error: ‘mode_t’ has not been declared 26 | mqd_t iox_mq_open4(const char* name, int oflag, mode_t mode, struct mq_attr* attr) | ^~~~~~ [1] https://man7.org/linux/man-pages/man3/mq_open.3.html Signed-off-by: Peter Seiderer <[email protected]>
e983806
to
296c055
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks for your contribution
bf42822
into
eclipse-iceoryx:master
As stated in the mq_open man page ([1]) the mqueue.h include needs additional sys/stat.h include for mode_t definition.
Fixes musl compile:
In file included from .../build/iceoryx-custom/iceoryx_platform/linux/source/mqueue.cpp:17:
.../build/iceoryx-custom/iceoryx_platform/linux/include/iceoryx_platform/mqueue.hpp:23:49: error: ‘mode_t’ has not been declared
23 | mqd_t iox_mq_open4(const char* name, int oflag, mode_t mode, struct mq_attr* attr);
| ^~~~~~
.../build/iceoryx-custom/iceoryx_platform/linux/source/mqueue.cpp:26:49: error: ‘mode_t’ has not been declared
26 | mqd_t iox_mq_open4(const char* name, int oflag, mode_t mode, struct mq_attr* attr)
| ^~~~~~
[1] https://man7.org/linux/man-pages/man3/mq_open.3.html
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References