Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving units::Duration #536

Open
2 of 4 tasks
elBoberido opened this issue Feb 1, 2021 · 4 comments · Fixed by #546 or #1929
Open
2 of 4 tasks

Improving units::Duration #536

elBoberido opened this issue Feb 1, 2021 · 4 comments · Fixed by #546 or #1929
Assignees
Labels
enhancement New feature globex good first issue Good for newcomers
Milestone

Comments

@elBoberido
Copy link
Member

elBoberido commented Feb 1, 2021

Brief feature description

The units::Duration class could have same additional features and improvements.

Detailed information

@elBoberido elBoberido added enhancement New feature good first issue Good for newcomers labels Feb 1, 2021
@enkeyz
Copy link
Contributor

enkeyz commented Feb 4, 2021

Could work on refactoring method names in units::Duration(first one), if it's still wanted.

@elfenpiff
Copy link
Contributor

@enkeyz It is still wanted and we would very much appreciate it!

I would assign the issue to you and if you run into troubles or other issues just contact us via https://gitter.im/eclipse/iceoryx

@elBoberido
Copy link
Member Author

@enkeyz sure, go ahead. If it's not too late, please rename the getter methods with a to prefix, so toDays, toNanoseconds. This makes it's less ambiguous than just nonoseconds which could also mean just to nanoseconds part of the duration.

@elfenpiff
Copy link
Contributor

Already finished with it, just one question: how to correctly run the "run_all_tests.sh" from tools folder?

@enkeyz nice!

Getting error message: "make: *** No rule to make target 'all_tests'. Stop."

I would recommend to use the iceoryx_meta approach for developing. Here you can compile and run the tests with the following commands:

cd iceoryx
cmake -Bbuild -Hiceoryx_meta -DBUILD_TEST=ON
cd build
make
make all_tests # executes all unit- and integrationtests

elBoberido added a commit that referenced this issue Feb 5, 2021
…-to-be-more-meaningful

iox-#536 refactored creation/getter method names in units::Duration
@elBoberido elBoberido reopened this Feb 5, 2021
@dkroenke dkroenke added the globex label Jun 8, 2022
@elBoberido elBoberido added this to the Low prio milestone Jun 9, 2022
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
…hrono' dependecy to 'iceoryx_dust'

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
…hrono' dependecy to 'iceoryx_dust'

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 8, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 8, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 8, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 8, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 8, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 8, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 8, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 8, 2023
…hrono' dependecy to 'iceoryx_dust'

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 8, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 8, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 8, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 9, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 9, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 9, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 10, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 10, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 10, 2023
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Mar 10, 2023
@elBoberido elBoberido reopened this Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature globex good first issue Good for newcomers
Projects
Status: To do
4 participants